-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC-0001] Memorandum on the authorization model #2212
Conversation
84ccd92
to
e549a93
Compare
5478a40
to
48eaaab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @squaremo 🏅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We've assigned 0001 to this RFC and moved #2086 to 0004. The reason for this change is that multi-tenancy builds upon the authorization model and shouldn't contain it. As such, RFC-0001 defines the authorization model and RFC-0004 defines the multi-tenancy model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@squaremo can you please rename the dir to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome explanation!! I love it.
b1a43bd
to
4c67bb3
Compare
This gives a baseline for future changes, e.g., expanding where namespace ACLs are used, switching access control to untrusted-by-default. The "Security considerations" section was adapted from #2086 Signed-off-by: Michael Bridgen <michael@weave.works>
4c67bb3
to
ede6785
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great level of detail of the current auth-N model, this is very helpful.
LGTM
This adds an RFC describing how authorisation works as of v0.24. This can then be a baseline for subsequent RFCs changing authorisation, e.g., namespace ACLs and default-untrusted deployments.